[AWSX-2144] feat(go-forwarder): add basic api key and config logic#1084
Merged
ndakkoune merged 16 commits intoMar 26, 2026
Conversation
ge0Aja
reviewed
Mar 20, 2026
Comment on lines
+56
to
+60
|
|
||
| if err := cfg.resolveAPIKey(ctx); err != nil { | ||
| return nil, fmt.Errorf("resolving API key: %w", err) | ||
| } | ||
|
|
ge0Aja
reviewed
Mar 20, 2026
ge0Aja
reviewed
Mar 20, 2026
ViBiOh
reviewed
Mar 20, 2026
ndakkoune
commented
Mar 24, 2026
ViBiOh
reviewed
Mar 24, 2026
| # SAM | ||
| .PHONY: build-ForwarderFunction sam-build sam-invoke sam-deploy | ||
|
|
||
| build-ForwarderFunction: |
Contributor
There was a problem hiding this comment.
💬 suggestion: Are we allowed to change case here? Can we stick to kebab-case? It's a mix of PascalCase and kebab-case that is disturbing.
Contributor
Author
There was a problem hiding this comment.
This command is (and should only be) used by the sam build command, which use whatever is written after build- to create a function named ForwarderFunction in the cloudformation template (local).
ViBiOh
approved these changes
Mar 25, 2026
Comment on lines
+15
to
+16
| func TestLoadConfig(t *testing.T) { | ||
| tests := map[string]struct { |
Contributor
There was a problem hiding this comment.
Suggested change
| func TestLoadConfig(t *testing.T) { | |
| tests := map[string]struct { | |
| func TestLoadConfig(t *testing.T) { | |
| t.Parallel() | |
| tests := map[string]struct { |
Contributor
Author
There was a problem hiding this comment.
t.Parallel() cannot be used with t.Setenv(k,v) since the latter affects the whole process.
| if !ok { | ||
| return fallback | ||
| } | ||
| return strings.EqualFold(v, "true") |
Contributor
There was a problem hiding this comment.
💭 thought: I'm wondering if we should support the "1" value etc?
You might prefere using ParseBool that will handle everything for you.
Contributor
Author
There was a problem hiding this comment.
We lose nothing by doing so. Let's use it.
|
|
||
| package config | ||
|
|
||
| //go:generate go tool mockgen -source=secretsmanager.go -package=config -destination=secretsmanager_mockgen.go |
Contributor
There was a problem hiding this comment.
We'll move the mock to a dedicated package later I think, to not have be part of the production bundle. Ok for now
Co-authored-by: Vincent Boutour <vincent.boutour@datadoghq.com>
Co-authored-by: Vincent Boutour <vincent.boutour@datadoghq.com>
Co-authored-by: Vincent Boutour <vincent.boutour@datadoghq.com>
Co-authored-by: Vincent Boutour <vincent.boutour@datadoghq.com>
ViBiOh
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add the logging initialization, the configuration, the api key retrieval/verification strategies and their tests.
Motivation
Following the migration of the Log Forwarder to Go, the logging, the api key retrieval/verification and the loading/declaration of the configuration are required to test the most basic version of the new forwarder.
Testing Guidelines
Additional Notes
HTTP_PROXYandHTTPS_PROXYenvironment variables. We will probably deprecate the SSL skipping related flags for now.Types of changes
Check all that apply